ENH allow stacked messages on FormMessage #10966
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
1 task
andrewandante
force-pushed
the
ENH/better_pwd_validation_msgs
branch
3 times, most recently
from
8b026c1 to
e765823
Compare
GuySartorelli
requested changes
Oct 3, 2023
|
Also FYI this has prompted me to make this issue for CMS 6 |
Hah yes that was definitely coming, I was reluctant to turn this into an API-breaking change but I think that would definitely be the best long-term approach. |
andrewandante
force-pushed
the
ENH/better_pwd_validation_msgs
branch
5 times, most recently
from
6329397 to
e90de56
Compare
|
Think I've managed to get my conditions in the right order now 😅 |
GuySartorelli
requested changes
Oct 5, 2023
andrewandante
force-pushed
the
ENH/better_pwd_validation_msgs
branch
from
e90de56 to
13fc402
Compare
GuySartorelli
requested changes
Oct 8, 2023
andrewandante
force-pushed
the
ENH/better_pwd_validation_msgs
branch
from
13fc402 to
4e7caa7
Compare
andrewandante
force-pushed
the
ENH/better_pwd_validation_msgs
branch
from
4e7caa7 to
a0cbebb
Compare
GuySartorelli
approved these changes
Oct 9, 2023
|
This will be included in the Silverstripe CMS 5.2.0 release. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #10270
Adds a new method:
FormMessage::appendMessage()which attempts to stack messages if it can, falling back to the current behaviour of setting the message if there's a mismatch.