ENH Allow selecting multiple (or no) tables #10953
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GuySartorelli
force-pushed
the
pulls/5/fix-table-from
branch
from
f40885a to
2c1bd14
Compare
GuySartorelli
commented
Sep 21, 2023
GuySartorelli
force-pushed
the
pulls/5/fix-table-from
branch
from
2c1bd14 to
8921c3f
Compare
GuySartorelli
changed the title
GuySartorelli
force-pushed
the
pulls/5/fix-table-from
branch
from
8921c3f to
11d5162
Compare
GuySartorelli
changed the title
GuySartorelli
force-pushed
the
pulls/5/fix-table-from
branch
from
11d5162 to
f0d1294
Compare
GuySartorelli
force-pushed
the
pulls/5/fix-table-from
branch
4 times, most recently
from
7b31cd0 to
024c965
Compare
emteknetnz
requested changes
Sep 24, 2023
GuySartorelli
force-pushed
the
pulls/5/fix-table-from
branch
from
024c965 to
09da83f
Compare
emteknetnz
approved these changes
Sep 24, 2023
This was referenced Sep 25, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently to select multiple tables in an SQLSelect query, you need to explicitly add a comma to subsequent tables in the FROM clause. This is a pretty bad smell, isn't intuitive or documented, and will make it harder to use Common Table Expressions (aka WITH clauses) once those are implemented - so this seems like a good time to remove that limitation.
Also allows selecting NO tables, e.g.
SELECT 1;is a perfectly valid SQL select statement. These can be useful in testing things like unions, but are also sometimes useful in Common Table Expressions.Issue