MNT Spelling error in Maori language name #10951
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sabina-talipova
force-pushed
the
pulls/5.1/fix-maori-spelling
branch
from
1f5d915 to
153092d
Compare
There was a problem hiding this comment.
I don't think we should make this change. The localeName method (which is where we would make this change if anywhere at all) uses Locale::getDisplayName(), which is a built-in PHP method. If PHP is giving the wrong output, it should be reported as a bug in PHP rather than us trying to work around it.
I'm going to close this PR for that reason.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Parent issue
Note
I'm not quite sure that we need this, since It prevents user to find "Māori" without macrons.