API Update method signature for CMSEditLink #1236
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GuySartorelli
force-pushed
the
pulls/6/standardise-cmseditlink
branch
from
46b5822 to
e8b061b
Compare
emteknetnz
requested changes
Aug 22, 2024
| @@ -68,7 +68,7 @@ class BlogPost extends DataObject | |||
| { | |||
| // ... | |||
|
|
|||
| public function CMSEditLink() | |||
| public function CMSEditLink(): ?string | |||
There was a problem hiding this comment.
Suggested change
| public function CMSEditLink(): ?string | |
| public function getCMSEditLink(): ?string |
src/Models/BaseElement.php
Outdated
| @@ -888,7 +888,7 @@ public function isCMSPreview() | |||
| * @return null|string | |||
| * @throws \SilverStripe\ORM\ValidationException | |||
| */ | |||
| public function CMSEditLink($directLink = false) | |||
| public function CMSEditLink($directLink = false): ?string | |||
There was a problem hiding this comment.
Suggested change
| public function CMSEditLink($directLink = false): ?string | |
| public function getCMSEditLink($directLink = false): ?string |
| @@ -27,7 +27,7 @@ class TestDataObjectWithCMSEditLink extends DataObject implements TestOnly | |||
| 'ElementalArea', | |||
| ]; | |||
|
|
|||
| public function CMSEditLink() | |||
| public function CMSEditLink(): ?string | |||
There was a problem hiding this comment.
Suggested change
| public function CMSEditLink(): ?string | |
| public function getCMSEditLink(): ?string |
| @@ -19,7 +19,7 @@ public function getMimeType() | |||
| return null; | |||
| } | |||
|
|
|||
| public function CMSEditLink() | |||
| public function CMSEditLink(): ?string | |||
There was a problem hiding this comment.
Suggested change
| public function CMSEditLink(): ?string | |
| public function getCMSEditLink(): ?string |
GuySartorelli
force-pushed
the
pulls/6/standardise-cmseditlink
branch
2 times, most recently
from
4342588 to
c620bc6
Compare
GuySartorelli
force-pushed
the
pulls/6/standardise-cmseditlink
branch
from
c620bc6 to
b0acd41
Compare
emteknetnz
approved these changes
Aug 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Relies on changes made in silverstripe/silverstripe-framework#11338
Issue