Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ENH Add config to control if a default author is added to posts on creation #669

Merged
merged 1 commit into from
Mar 3, 2022

Conversation

jellygnite
Copy link
Contributor

No description provided.

@GuySartorelli
Copy link
Member

Note: there is some discussion about this in #668

.gitignore Outdated Show resolved Hide resolved
@dhensby
Copy link
Contributor

dhensby commented Mar 3, 2022

How do you feel about adding a test to cover this new behaviour?

@jellygnite
Copy link
Contributor Author

jellygnite commented Mar 3, 2022 via email

Copy link
Contributor

@dhensby dhensby left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll approve it as is, but leave it to another contributor to agree and merge

@michalkleiner
Copy link
Contributor

Created a new enhancement issue for adding the tests — #670.

@michalkleiner michalkleiner merged commit e9507b7 into silverstripe:3 Mar 3, 2022
@michalkleiner
Copy link
Contributor

@jellygnite thank you for dipping your toes in the PR waters and submitting your contribution, we do appreciate each and every one of them.

With the tests, there's a new issue for it (linked above), so when (and if) you feel ready, give it a go. In the linked test file there are already existing tests for other aspects of the BlogPost class, so you can take some hints/inspiration from there. Definitely give it a try, submit your change as a new PR, and when a maintainer here has a bit of time, they can help you push it over the line.

@jellygnite jellygnite deleted the new-branch branch March 4, 2022 00:02
@jellygnite jellygnite restored the new-branch branch March 4, 2022 00:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants