-
Notifications
You must be signed in to change notification settings - Fork 168
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ENH Add config to control if a default author is added to posts on creation #669
Conversation
Note: there is some discussion about this in #668 |
How do you feel about adding a test to cover this new behaviour? |
I would feel great if I knew how. I’ve not delved into testing yet. I will need to understand it first.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'll approve it as is, but leave it to another contributor to agree and merge
Created a new enhancement issue for adding the tests — #670. |
@jellygnite thank you for dipping your toes in the PR waters and submitting your contribution, we do appreciate each and every one of them. With the tests, there's a new issue for it (linked above), so when (and if) you feel ready, give it a go. In the linked test file there are already existing tests for other aspects of the BlogPost class, so you can take some hints/inspiration from there. Definitely give it a try, submit your change as a new PR, and when a maintainer here has a bit of time, they can help you push it over the line. |
No description provided.