Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FIX Respect strict-typing of Factory interface #85

Merged
merged 1 commit into from
Jul 12, 2024
Merged

FIX Respect strict-typing of Factory interface #85

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion code/AuditFactory.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,7 @@
use Monolog\Handler\SyslogHandler;
use Monolog\Logger;
use Monolog\Processor\WebProcessor;
use Psr\Log\LoggerInterface;
use SilverStripe\Core\Injector\Factory;

/**
Expand All @@ -15,7 +16,7 @@
*/
class AuditFactory implements Factory
{
public function create($service, array $params = [])
public function create(string $service, array $params = []): LoggerInterface
{
if (!empty($params)) {
throw new Exception('AuditFactory does not support passing params.');
Expand Down
Loading