API Remove deprecated extension hooks #1880
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 tasks
We don't really have a way to deprecate these per-se, but they were removed in other admin sections already so it's time to remove them from here as well.
GuySartorelli
force-pushed
the
pulls/3.0/remove-deprecated
branch
from
7a30660 to
e485142
Compare
GuySartorelli
commented
Jan 6, 2025
| @@ -45,7 +45,6 @@ | |||
| use SilverStripe\Model\ArrayData; | |||
| use SilverStripe\View\Requirements; | |||
| use SilverStripe\View\SSViewer; | |||
| use SilverStripe\Dev\Deprecation; | |||
GuySartorelli
commented
Jan 6, 2025
| @@ -10,7 +10,6 @@ | |||
| use SilverStripe\Control\HTTPResponse; | |||
| use SilverStripe\Core\Injector\Injector; | |||
| use SilverStripe\Forms\Form; | |||
| use SilverStripe\Dev\Deprecation; | |||
GuySartorelli
commented
Jan 6, 2025
Comment on lines
-324
to
-335
| // Remove default and add our own filter header with extension points | ||
| // to retain API until deprecation in 5.0 | ||
| $config->removeComponentsByType(GridFieldFilterHeader::class); | ||
| $config->addComponent(Injector::inst()->createWithArgs(GridFieldFilterHeader::class, [ | ||
| false, | ||
| function ($context) { | ||
| $this->extend('updateSearchContext', $context); | ||
| }, | ||
| function ($form) { | ||
| $this->extend('updateSearchForm', $form); | ||
| } | ||
| ])); |
There was a problem hiding this comment.
We don't really have a way to deprecate these per-se, but they were removed in other admin sections already so it seems sensible to remove them from here as well.
This code was added in #665 which moved the search context from ModelAdmin into GridFieldFilterHeader - it seems clear the intention was to completely shift responsibility of managing it out of the controller and into the gridfield coponent.
Developers who need to update these can either:
- update the component from their own subclass of
ModelAdmin - update the search context in their
DataObjectsubclass
EDIT:
These don't work anyway lol. The code for them was deprecated in CMS 4 and then subsequently removed in CMS 5.
emteknetnz
approved these changes
Jan 7, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue