DOC Replace Extension subclasses #566
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
emteknetnz
force-pushed
the
pulls/6/replace-extension-subclasses
branch
from
539ee35 to
5f137c9
Compare
emteknetnz
changed the title
emteknetnz
force-pushed
the
pulls/6/replace-extension-subclasses
branch
from
5f137c9 to
5b3991e
Compare
emteknetnz
force-pushed
the
pulls/6/replace-extension-subclasses
branch
2 times, most recently
from
69af9c6 to
c82b2af
Compare
| @@ -338,6 +338,7 @@ Injector::inst()->load([ | |||
| - [`DataObject::write()`](api:SilverStripe\ORM\DataObject::write()) has a new boolean `$skipValidation` parameter. This can be useful for scenarios where you want to automatically create a new record with no data initially without restricting how developers can set up their validation rules. | |||
| - [`FieldList`](api:SilverStripe\Forms\FieldList) is now strongly typed. Methods that previously allowed any iterable variables to be passed, namely [`FieldList::addFieldsToTab()`](api:SilverStripe\Forms\FieldList::addFieldsToTab()) and [`FieldList::removeFieldsFromTab()`](api:SilverStripe\Forms\FieldList::removeFieldsFromTab()), now require an array to be passed instead. | |||
| - [`BaseElement::getDescription()`](api:DNADesign\Elemental\Models\BaseElement::getDescription()) has been removed. If you had implemented this method in your custom elemental blocks, either set the [`description`](api:DNADesign\Elemental\Models\BaseElement->description) configuration property or override the [`getTypeNice()`](api:DNADesign\Elemental\Models\BaseElement::getTypeNice()) method. | |||
| - [`DataExtension`](api:SilverStripe\ORM\DataExtension), [`SiteTreeExtension`](api:SilverStripe\CMS\Model\SiteTreeExtension), and [`LeftAndMainExtension`](api:SilverStripe\Admin\LeftAndMainExtension) have been removed. If you subclass any of these classes, you must now subclass [`Extension`](api:SilverStripe\Core\Extension) instead. | |||
There was a problem hiding this comment.
I would almost suggest this gets its own heading, since these are exceptionally high traffic classes. But it's probably fine here like this.
There was a problem hiding this comment.
Also, I just realised that the API links won't work for these - don't bother fixing that right now, there's a bunch of similar links that will stop working in this changelog. We can resolve that when we do the first alpha by giving it a once-over.
emteknetnz
force-pushed
the
pulls/6/replace-extension-subclasses
branch
from
c82b2af to
334a9af
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue silverstripe/silverstripe-framework#11050
Note that re the changelog - this was also mentioned in the #563, and we don't normally repeat that in the 6.0.0 changelog, however Deprecation::withNoReplacement() was used in that CMS 5 PRs which will prevent the deprecation notices from showing in CMS 5, so I think we should at least mention this in the CMS 6 changelog