-
Notifications
You must be signed in to change notification settings - Fork 67
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
DOC Update react injector docs to work #215
DOC Update react injector docs to work #215
Conversation
30d6f40
to
1a9525d
Compare
Could we also fix this small spelling issue Line 1412 in 1a9525d
And small question: why we use somewhere |
It's to distinguish between the two contexts this documentation is bouncing between - there's a module which provides the notes components and the actual Really this whole section of docs needs to be reconsidered, probably being split into a more traditional "here is the API and how it works" and then these examples should be moved into a "how to" section and fleshed out a bit more. But that's not in scope for this PR where I'm just trying to make sure the examples work at all. |
We should, probably, update this section. Since information presented in |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you fix spelling mistake cient
to client
Line 1412 in 1a9525d
**my-module/cient/src/state/createNote.js** |
I've made a note about this in #129, which is about reviewing the structure and general content of front-end related documentation. It falls outside the scope of this PR, which is really just about making the graphql code examples work - not necessarily about making them clear and easy to understand. In other words, we'll do this in stages:
For the purposes of testing this PR, I'll send you the project I used to do so with information about how to use it for testing this PR. |
1a9525d
to
dc979b0
Compare
I've fixed the typo. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGFM
Reapplies the changes to graphql injector docs that were (meant to be) reverted (along with any new changes I found that were required)
NOTE
The revert commit was not completed correctly. It was meant to revert the entirety of #187 and #197, but failed to do so!
That's okay because this commit would have partially reinstated those PRs anyway.
Make sure you test and review the entirety of the graphql/javascript code from
## Using Injector to customise GraphQL queries
to the end of the file. That includes both the graphql 3 and graphql 4 sections! ALL of that is in scope for this PR.Requires extra admin PR also
Issue