DOC Update history viewer GraphQL examples for CMS 5 #196
Conversation
GuySartorelli
force-pushed
the
pulls/5.0/graphql-examples
branch
2 times, most recently
from
744c10c to
4dcf177
Compare
| onmatch() { | ||
| ReactDOM.render( | ||
| const root = createRoot(this[0]); |
There was a problem hiding this comment.
Just question, what do we have in this[0] exactly? Probably we could add a short comment to explain this in code snippet.
There was a problem hiding this comment.
this[0] is a fairly common way in jQuery to say "Give me the underlying node that this jQuery object represents so I can use it with non-jQuery code". I'll add a comment when you've done with your review and assigned it back.
There was a problem hiding this comment.
This part is no longer in this PR - see #247 instead.
|
Looks good. Could you add comments for this, please. |
GuySartorelli
force-pushed
the
pulls/5.0/graphql-examples
branch
from
4dcf177 to
2d584b3
Compare
GuySartorelli
changed the title
Remove mention of GraphQL v3
GuySartorelli
force-pushed
the
pulls/5.0/graphql-examples
branch
from
2d584b3 to
77ce46d
Compare
|
@sabina-talipova Do you remember what comments you wanted on this? |
In this comment you mentioned that you will update comment for |
Following on from #211, removes mention of GraphQL v3 and updates javascript to work with the CMS 5 dependencies.
Issue