Remove action delegates for configuration

[johnml1135]

This addresses #518.

---

This change is 

[codecov-commenter]

Codecov Report

Attention: Patch coverage is 37.03704% with 17 lines in your changes missing coverage. Please review.

Project coverage is 57.25%. Comparing base (c45a597) to head (0b418c3).
Report is 1 commits behind head on main.

Files with missing lines	Patch %	Lines
....Shared/Configuration/IMachineBuilderExtensions.cs	0.00%	8 Missing ⚠️
...ared/Configuration/IServiceCollectionExtensions.cs	0.00%	7 Missing ⚠️
...val.Machine.Shared/Configuration/MachineBuilder.cs	0.00%	2 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##             main     #537      +/-   ##
==========================================
+ Coverage   56.97%   57.25%   +0.27%     
==========================================
  Files         299      299              
  Lines       15741    15664      -77     
  Branches     2174     2163      -11     
==========================================
- Hits         8969     8968       -1     
+ Misses       6122     6054      -68     
+ Partials      650      642       -8     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[ddaspit]

Reviewed 6 of 6 files at r1, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @johnml1135)

---

src/Machine/src/Serval.Machine.Shared/Configuration/IServiceCollectionExtensions.cs line 5 at r1 (raw file):

public static class IServiceCollectionExtensions
{
    public static IMachineBuilder AddMachine(this IServiceCollection services, IConfiguration? configuration = null)

configuration no longer needs to be optional. Then you won't need to check if configuration is null. You should do the same for the AddServal method as well.

[johnml1135]

src/Machine/src/Serval.Machine.Shared/Configuration/IServiceCollectionExtensions.cs line 5 at r1 (raw file):

Previously, ddaspit (Damien Daspit) wrote…

configuration no longer needs to be optional. Then you won't need to check if configuration is null. You should do the same for the AddServal method as well.

Done.

[ddaspit]

Reviewed 10 of 10 files at r2, all commit messages.
Reviewable status: all files reviewed, 2 unresolved discussions (waiting on @johnml1135)

---

src/Serval/src/Serval.Assessment/Configuration/IServalBuilderExtensions.cs line 18 at r2 (raw file):

        var assessmentOptions = new AssessmentOptions();
        builder.Configuration?.GetSection(AssessmentOptions.Key).Bind(assessmentOptions);

We don't need the null-conditional operator anymore.

---

src/Serval/src/Serval.Translation/Configuration/IServalBuilderExtensions.cs line 18 at r2 (raw file):

        var translationOptions = new TranslationOptions();
        builder.Configuration?.GetSection(TranslationOptions.Key).Bind(translationOptions);

We don't need the null-conditional operator anymore.

[johnml1135]

src/Serval/src/Serval.Translation/Configuration/IServalBuilderExtensions.cs line 18 at r2 (raw file):

Previously, ddaspit (Damien Daspit) wrote…

We don't need the null-conditional operator anymore.

Fixed all.

[johnml1135]

src/Serval/src/Serval.Assessment/Configuration/IServalBuilderExtensions.cs line 18 at r2 (raw file):

Previously, ddaspit (Damien Daspit) wrote…

We don't need the null-conditional operator anymore.

Done.

[ddaspit]

Reviewed 4 of 4 files at r3, all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @johnml1135)