Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

So we don't pretranslate everything #519

Merged
merged 2 commits into from
Oct 24, 2024
Merged

So we don't pretranslate everything #519

merged 2 commits into from
Oct 24, 2024

Conversation

johnml1135
Copy link
Collaborator

@johnml1135 johnml1135 commented Oct 23, 2024

This change is Reviewable

@johnml1135 johnml1135 requested a review from ddaspit October 23, 2024 19:52
@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 56.67%. Comparing base (bdf43fa) to head (87388c5).

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #519   +/-   ##
=======================================
  Coverage   56.67%   56.67%           
=======================================
  Files         299      299           
  Lines       15626    15627    +1     
  Branches     2154     2155    +1     
=======================================
+ Hits         8856     8857    +1     
  Misses       6114     6114           
  Partials      656      656           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@ddaspit ddaspit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 2 of 2 files at r1, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @johnml1135)

@johnml1135 johnml1135 merged commit 0b06fbf into main Oct 24, 2024
3 checks passed
@johnml1135 johnml1135 deleted the sf_test_fix branch October 24, 2024 14:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants