Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Log the headers #493

Merged
merged 1 commit into from
Sep 16, 2024
Merged

Log the headers #493

merged 1 commit into from
Sep 16, 2024

Conversation

johnml1135
Copy link
Collaborator

@johnml1135 johnml1135 commented Sep 16, 2024

#492


This change is Reviewable

@johnml1135 johnml1135 requested a review from Enkidu93 September 16, 2024 16:47
Copy link
Collaborator

@Enkidu93 Enkidu93 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 1 of 1 files at r1, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @johnml1135)

@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 0% with 9 lines in your changes missing coverage. Please review.

Project coverage is 57.05%. Comparing base (2644f51) to head (20ba476).

Files with missing lines Patch % Lines
...c/Serval.Machine.Shared/Services/ClearMLService.cs 0.00% 9 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #493      +/-   ##
==========================================
- Coverage   57.08%   57.05%   -0.04%     
==========================================
  Files         277      277              
  Lines       14157    14165       +8     
  Branches     1900     1901       +1     
==========================================
  Hits         8082     8082              
- Misses       5487     5495       +8     
  Partials      588      588              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@johnml1135 johnml1135 merged commit 8c5f802 into main Sep 16, 2024
3 checks passed
@ddaspit ddaspit deleted the log_clearml_error_headers branch September 16, 2024 19:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants