Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update logging #483

Merged
merged 2 commits into from
Sep 10, 2024
Merged

Update logging #483

merged 2 commits into from
Sep 10, 2024

Conversation

johnml1135
Copy link
Collaborator

@johnml1135 johnml1135 commented Sep 10, 2024

Log failing health checks: #482
Log engine activy #433 - the super simple implementation.


This change is Reviewable

@johnml1135 johnml1135 requested a review from ddaspit September 10, 2024 00:45
@codecov-commenter
Copy link

codecov-commenter commented Sep 10, 2024

Codecov Report

Attention: Patch coverage is 62.06897% with 11 lines in your changes missing coverage. Please review.

Project coverage is 56.60%. Comparing base (c7f1214) to head (efa70ff).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
...lation/Controllers/TranslationEnginesController.cs 65.00% 7 Missing ⚠️
...c/Serval.ApiServer/Controllers/StatusController.cs 55.55% 4 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #483      +/-   ##
==========================================
+ Coverage   56.59%   56.60%   +0.01%     
==========================================
  Files         275      275              
  Lines       14174    14203      +29     
  Branches     1908     1910       +2     
==========================================
+ Hits         8022     8040      +18     
- Misses       5563     5574      +11     
  Partials      589      589              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

* Ignore all the HttpClient requests to the world
* Log each time a translation (or similar) is requested.
@johnml1135 johnml1135 changed the title Log bad health checks Update logging Sep 10, 2024
Copy link
Contributor

@ddaspit ddaspit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 1 of 1 files at r1, 6 of 6 files at r2, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @johnml1135)

@johnml1135 johnml1135 merged commit b0ec200 into main Sep 10, 2024
3 checks passed
@johnml1135 johnml1135 deleted the log_unhealthy branch September 10, 2024 17:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants