Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Separate repos in e2e tests #185

Merged
merged 5 commits into from
Oct 18, 2023
Merged

Separate repos in e2e tests #185

merged 5 commits into from
Oct 18, 2023

Conversation

Enkidu93
Copy link
Collaborator

@Enkidu93 Enkidu93 commented Oct 18, 2023

Fixes #158


This change is Reviewable

@Enkidu93 Enkidu93 requested a review from johnml1135 October 18, 2023 18:50
@Enkidu93
Copy link
Collaborator Author

Once this is merged, I'll take care of the Machine side, but since Machine is pulling from Serval main, my updates won't work until these are made here.

@johnml1135
Copy link
Collaborator

If this works, it works!

Copy link
Collaborator

@johnml1135 johnml1135 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 2 of 2 files at r1, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @Enkidu93)

@johnml1135 johnml1135 merged commit ea51780 into main Oct 18, 2023
1 of 2 checks passed
@Enkidu93 Enkidu93 deleted the separate_repos_in_e2e_tests branch October 18, 2023 20:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

E2E - don't have adjacent folders
2 participants