-
-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added open telemetry instrumentation #88
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
See my comments on the corresponding Serval PR.
Reviewed 3 of 3 files at r1, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @Enkidu93 and @johnml1135)
src/SIL.Machine.AspNetCore/SIL.Machine.AspNetCore.csproj
line 37 at r1 (raw file):
<PackageReference Include="Microsoft.AspNetCore.Mvc.NewtonsoftJson" Version="6.0.16" /> <PackageReference Include="Microsoft.Extensions.Http.Polly" Version="6.0.14" /> <PackageReference Include="OpenTelemetry.Exporter.Console" Version="1.6.0" />
I would move these package references to the individual server projects, since this project has no dependency on OpenTelemetry.
Doesn't this need a subscription to the mongo DB - or do I nut understand: https://github.com/jbogard/MongoDB.Driver.Core.Extensions.DiagnosticSources? |
Previously, johnml1135 (John Lambert) wrote…
You are correct. I've already added that in Serval (see the other PR). And Machine calls that code here. (And I can verify that it works locally; I'm getting appropriate traces from MongoDB in all containers). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 5 of 5 files at r2, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @johnml1135)
aad9008
to
2c08e0f
Compare
@johnml1135 Do you want this to be merged or would you rather I put the console exporter behind a development flag first? |
Please do - I don't want it spamming production logging. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 5 of 5 files at r2, all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @Enkidu93)
@johnml1135 I hadn't yet added that. I'll make another PR I guess. I'm sorry - I just got out of a long meeting. |
Fixes sillsdev/serval#58
This change is