Fixes Throw error for unbuilt engine #81

[Enkidu93]

This change is 

[Enkidu93]

I've switched to Aborted so no changes are needed on the Serval side.

[ddaspit]

Reviewed 2 of 2 files at r1, 1 of 1 files at r2, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @Enkidu93 and @johnml1135)

---

src/SIL.Machine.AspNetCore/Services/TranslationEngineServiceBase.cs line 225 at r2 (raw file):

        TranslationEngine engine = await GetEngineAsync(engineId, cancellationToken);
        if (engine.BuildState != BuildState.None || engine.BuildRevision == 0) //TranslationEngine.Revision - I don't see it used anywhere
            throw new RpcException(new Status(StatusCode.Aborted, "The engine must be built first"));

You should not throw an RpcException from here. RpcException is a gRPC-specific exception. This layer of the system should not be coupled to gRPC. You should probably create a new EngineNotBuildException or something like that.

[johnml1135]

src/SIL.Machine.AspNetCore/Services/TranslationEngineServiceBase.cs line 217 at r2 (raw file):

        TranslationEngine? engine = await Engines.GetAsync(e => e.EngineId == engineId, cancellationToken);
        if (engine is null)
            throw new InvalidOperationException("");

Shouldn't this throw a better error message? Like "Couldn't find engine 12345"?

[johnml1135]

Reviewed all commit messages.
Reviewable status: all files reviewed, 2 unresolved discussions (waiting on @Enkidu93)

[Enkidu93]

Reviewable status: 1 of 4 files reviewed, 2 unresolved discussions (waiting on @ddaspit and @johnml1135)

---

src/SIL.Machine.AspNetCore/Services/TranslationEngineServiceBase.cs line 217 at r2 (raw file):

Previously, johnml1135 (John Lambert) wrote…

Shouldn't this throw a better error message? Like "Couldn't find engine 12345"?

I added one. It is caught almost immediately, but even so, it seems like it couldn't hurt to include a message.

---

src/SIL.Machine.AspNetCore/Services/TranslationEngineServiceBase.cs line 225 at r2 (raw file):

Previously, ddaspit (Damien Daspit) wrote…

You should not throw an RpcException from here. RpcException is a gRPC-specific exception. This layer of the system should not be coupled to gRPC. You should probably create a new EngineNotBuildException or something like that.

Done.

[ddaspit]

Reviewed 4 of 4 files at r3, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @johnml1135)

[johnml1135]

Reviewed all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @Enkidu93)

[johnml1135]

Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @Enkidu93)