Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes https://github.com/sillsdev/serval/issues/95 --ECL #72

Merged
merged 1 commit into from
Sep 5, 2023
Merged

Fixes https://github.com/sillsdev/serval/issues/95 --ECL #72

merged 1 commit into from
Sep 5, 2023

Conversation

Enkidu93
Copy link
Collaborator

@Enkidu93 Enkidu93 commented Sep 5, 2023 •
edited by ddaspit
Loading

This change is Reviewable

@Enkidu93 Enkidu93 requested a review from ddaspit September 5, 2023 13:40
@Enkidu93 Enkidu93 mentioned this pull request Sep 5, 2023
Closed
johnml1135
johnml1135 approved these changes Sep 5, 2023
View reviewed changes
Copy link
Collaborator

@johnml1135 johnml1135 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 2 of 2 files at r1, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @ddaspit)

ddaspit
ddaspit approved these changes Sep 5, 2023
View reviewed changes
Copy link
Contributor

@ddaspit ddaspit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 2 of 2 files at r1, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @Enkidu93)

@Enkidu93 Enkidu93 force-pushed the inconsistent_behavior_on_build_when_already_building branch from 405bea5 to fd6e813 Compare September 5, 2023 18:02
johnml1135
johnml1135 approved these changes Sep 5, 2023
View reviewed changes
Copy link
Collaborator

@johnml1135 johnml1135 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 1 of 1 files at r2, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @Enkidu93)

@Enkidu93 Enkidu93 force-pushed the inconsistent_behavior_on_build_when_already_building branch from fd6e813 to 275f362 Compare September 5, 2023 18:32
@Enkidu93 Enkidu93 merged commit 5e5312f into master Sep 5, 2023
3 checks passed
@Enkidu93 Enkidu93 deleted the inconsistent_behavior_on_build_when_already_building branch September 5, 2023 18:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@johnml1135 johnml1135 johnml1135 approved these changes

@ddaspit ddaspit ddaspit approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Enkidu93 @ddaspit @johnml1135