Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove Serval engine #219

Merged
merged 1 commit into from
Jul 10, 2024
Merged

Remove Serval engine #219

merged 1 commit into from
Jul 10, 2024

Conversation

ddaspit
Copy link
Contributor

@ddaspit ddaspit commented Jul 10, 2024

This change is Reviewable

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 69.62%. Comparing base (d666e69) to head (08efecd).

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #219      +/-   ##
==========================================
+ Coverage   67.04%   69.62%   +2.57%     
==========================================
  Files         455      374      -81     
  Lines       35925    31292    -4633     
  Branches     4762     4382     -380     
==========================================
- Hits        24087    21786    -2301     
+ Misses      10745     8488    -2257     
+ Partials     1093     1018      -75     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@johnml1135 johnml1135 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 239 of 239 files at r1, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @ddaspit)

@johnml1135 johnml1135 merged commit 6979680 into master Jul 10, 2024
4 checks passed
@johnml1135 johnml1135 deleted the remove-engine branch July 10, 2024 17:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants