Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Renamed and reimplemented GetFromRegistryProgramThatOpensFileType #1361

Merged
merged 1 commit into from
Nov 14, 2024

Conversation

tombogle
Copy link
Contributor

@tombogle tombogle commented Nov 8, 2024

Renamed GetFromRegistryProgramThatOpensFileType to GetDefaultProgramForFileType and implemented it in a way that works on Windows 11, Mono (probably) and MacOS (untested).


This change is Reviewable

…orFileType and implemented it in a way that works on Windows 11, Mono (probably) and MacOS (untested)
Copy link

github-actions bot commented Nov 8, 2024

LibPalaso Tests

    45 files  ±0      45 suites  ±0   12m 26s ⏱️ +31s
 4 830 tests ±0   4 599 ✅ ±0  231 💤 ±0  0 ❌ ±0 
14 008 runs  ±0  13 381 ✅ ±0  627 💤 ±0  0 ❌ ±0 

Results for commit 00528d3. ± Comparison against base commit de37405.

This pull request removes 3 and adds 3 tests. Note that renamed tests count towards both.
SIL.Tests.IO.FileLocatorTests ‑ GetFromRegistryProgramThatOpensFileType_SendExtensionWithoutPeriod_ReturnsProgramPath
SIL.Tests.IO.FileLocatorTests ‑ GetFromRegistryProgramThatOpensFileType_SendInvalidType_ReturnsNull
SIL.Tests.IO.FileLocatorTests ‑ GetFromRegistryProgramThatOpensFileType_SendValidType_ReturnsProgramPath
SIL.Tests.IO.FileLocatorTests ‑ GetDefaultProgramForFileType_SendExtensionWithoutPeriod_ReturnsProgramPath
SIL.Tests.IO.FileLocatorTests ‑ GetDefaultProgramForFileType_SendInvalidType_ReturnsNull
SIL.Tests.IO.FileLocatorTests ‑ GetDefaultProgramForFileType_SendValidType_ReturnsProgramPath

Copy link
Collaborator

@josephmyers josephmyers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note that, given the test project targets .NET8, you could easily test Linux (not Mono) if you have access to it. I think a one-time verification for this PR would be beneficial, if possible. Other than that, the code here looks good to me

@tombogle
Copy link
Contributor Author

I don't have a Linux machine. In some theoretical world, I could probably spin up a VM, but I doubt I'd ever got to it. I agree that it would be ideal.

@tombogle tombogle merged commit 1c95083 into master Nov 14, 2024
3 checks passed
@tombogle tombogle deleted the file-locator-improvements branch November 14, 2024 18:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants