Replaced dependency on DotNetZip with System.IO.Compression.ZipFile

[tombogle]

This change is 

[github-actions]

LibPalaso Tests

   39 files   -     6     39 suites   - 6   5m 29s ⏱️ - 6m 26s
2 818 tests  - 2 012  2 644 ✅  - 1 955  161 💤  -  70  13 ❌ +13 
7 924 runs   - 6 084  7 533 ✅  - 5 848  378 💤  - 249  13 ❌ +13 

For more details on these failures, see this check.

Results for commit aae892c. ± Comparison against base commit de37405.

This pull request removes 2012 tests.

SIL.DictionaryServices.Tests.Lift.EmbeddedXmlCollectionCloneableTests ‑ CloneCopiesAllNeededMembers
SIL.DictionaryServices.Tests.Lift.EmbeddedXmlCollectionCloneableTests ‑ Equal_ItemsAreEqual_ReturnsTrue
SIL.DictionaryServices.Tests.Lift.EmbeddedXmlCollectionCloneableTests ‑ Equal_OneFieldDiffers_ReturnsFalse
SIL.DictionaryServices.Tests.Lift.EmbeddedXmlCollectionCloneableTests ‑ Equal_SecondFieldIsNull_ReturnsFalse
SIL.DictionaryServices.Tests.Lift.EmbeddedXmlCollectionCloneableTests ‑ Equals_OtherIsNull_ReturnsFalse
SIL.DictionaryServices.Tests.Lift.EmbeddedXmlCollectionCloneableTests ‑ ObjectEquals_OtherIsNull_ReturnsFalse
SIL.DictionaryServices.Tests.Lift.FlagStateCloneableTests ‑ CloneCopiesAllNeededMembers
SIL.DictionaryServices.Tests.Lift.FlagStateCloneableTests ‑ Equal_ItemsAreEqual_ReturnsTrue
SIL.DictionaryServices.Tests.Lift.FlagStateCloneableTests ‑ Equal_OneFieldDiffers_ReturnsFalse
SIL.DictionaryServices.Tests.Lift.FlagStateCloneableTests ‑ Equal_SecondFieldIsNull_ReturnsFalse
…

♻️ This comment has been updated with latest results.

[hatton]

Reviewable status: 0 of 11 files reviewed, 1 unresolved discussion (waiting on @andrew-polk, @josephmyers, and @tombogle)

---

a discussion (no related file):
What problem is this change solving?
Can you confirm that the unit tests covered corner cases like non-ascii characters?

[tombogle]

Previously, hatton (John Hatton) wrote…

What problem is this change solving?
Can you confirm that the unit tests covered corner cases like non-ascii characters?

The DotNetZip package is now deprecated. Not sure that it actually represented any vulnerability or problem, but since we're making a bunch of other breaking changes and updating dependencies, this seemed like the right time to bite the bullet and switch to a package that is going to be actively maintained. I don't think any of the existing unit tests checked for handling special characters, but I just tweaked one of them to prove that it works. Not 100% sure that's what you had in mind.

[josephmyers]

The code overall looks good, thanks for doing this. But take a look at the test failures. They look legitimate. Some version conflicts, probably due to the changed references

[hahn-kev]

looks good to me, I left a comment about RAMP as there was an old comment which was lost about it being picky about the zip file

[github-actions]

Palaso Tests

     3 files  ±0       3 suites  ±0   14m 22s ⏱️ - 1m 54s
 4 824 tests ±0   4 593 ✅ +1  231 💤 ±0  0 ❌  - 1 
13 996 runs  ±0  13 369 ✅ +1  627 💤 ±0  0 ❌  - 1 

Results for commit 11005e6. ± Comparison against base commit 1c95083.

Stale

[tombogle]

@hatton @hahn-kev, if you guys are happy, please go ahead and release this PR from purgatory.

[hatton]

Reviewable status: 0 of 11 files reviewed, 2 unresolved discussions (waiting on @andrew-polk, @hahn-kev, and @tombogle)

---

a discussion (no related file):

Previously, tombogle (Tom Bogle) wrote…

The DotNetZip package is now deprecated. Not sure that it actually represented any vulnerability or problem, but since we're making a bunch of other breaking changes and updating dependencies, this seemed like the right time to bite the bullet and switch to a package that is going to be actively maintained. I don't think any of the existing unit tests checked for handling special characters, but I just tweaked one of them to prove that it works. Not 100% sure that's what you had in mind.

Sorry, I don't have the margin to follow up and look at details here. I just wanted to raise the issue.

[tombogle]

Previously, hatton (John Hatton) wrote…

Sorry, I don't have the margin to follow up and look at details here. I just wanted to raise the issue.

Done.