Separated test runs by framework to avoid file-locking conflicts

[tombogle]

This change is 

[github-actions]

LibPalaso Tests

    45 files  ±0      45 suites  ±0   13m 44s ⏱️ + 3m 12s
 4 830 tests +2   4 598 ✅ +5  231 💤 ±0  1 ❌  - 3 
14 008 runs  +6  13 380 ✅ +9  627 💤 ±0  1 ❌  - 3 

For more details on these failures, see this check.

Results for commit 053a640. ± Comparison against base commit 46fa5f0.

♻️ This comment has been updated with latest results.

[jasonleenaylor]

.github/workflows/build.yml line 61 at r2 (raw file):

        files: |
          ./test-results/netcoreapp2.1/**/*.trx
          ./test-results/net6.0/**/*.trx

I don't think this change is needed, the glob should pick up all 3 folders.

[jasonleenaylor]

.github/workflows/build.yml line 25 at r2 (raw file):

    - name: Build project - Debug
      run: dotnet build -bl:build.dbg.binlog --configuration Debug

Curious why you wanted to have both a debug & release build?

[tombogle]

Reviewable status: 0 of 1 files reviewed, all discussions resolved (waiting on @hahn-kev, @jasonleenaylor, and @josephmyers)

---

.github/workflows/build.yml line 25 at r2 (raw file):

Previously, jasonleenaylor (Jason Naylor) wrote…

Curious why you wanted to have both a debug & release build?

I believe that's what it was doing before. It already did the release build upfront. But then each test run would rebuild it (in debug). But it seems this was maybe part of what was causing file locking issues since the test runs were apparently running in parallel. So now it does the debug build once upfront. Since there is the possibility of it successfully building in release but not in debug or vice versa, it seems safest to try both builds to be sure they both succeed. (Pretty sure most of our builds for other software does this as well.) I'm definitely kind of new to GHA and YAML, so if something I've said seems to contradict reality, feel free to challenge me.

---

.github/workflows/build.yml line 61 at r2 (raw file):

Previously, jasonleenaylor (Jason Naylor) wrote…

I don't think this change is needed, the glob should pick up all 3 folders.

I think you're right. I think the following commit proved to be the magic bullet.

[josephmyers]

I believe Kevin is going to leave a more complete review, but the most obvious thing here is that two of the frameworks are bogus. The fact that this passes is concerning. Apparently, false positives (silent failures) can happen if the projects are not marked with IsTestProject. I opened a new PR which utilizes the GHA matrix feature to separate things and marks our projects with the flag. (I needed a separate PR to fiddle with GHA silliness)

#1362

We also need a check to verify that our three supported frameworks actually have at least a certain number of tests run. We can do this in another task.

[josephmyers]

I'm closing this in favor of using the concurrency built into GHA, #1362