Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix l10n workflows by using latest dotnet version #1339

Merged
merged 1 commit into from
Aug 15, 2024

Conversation

hahn-kev
Copy link
Contributor

@hahn-kev hahn-kev commented Aug 15, 2024

the Update l10n workflow is broken since #1336 was merged in. This wasn't caught as part of the PR because those workflows don't run.

Now these 2 workflows will always use the latest version of dotnet, this should help us avoid this issue in the future if projects target dotnet 9 etc.


This change is Reviewable

@hahn-kev hahn-kev requested a review from ermshiperete August 15, 2024 08:31
Copy link

LibPalaso Tests

   18 files  ± 0     18 suites  ±0   7m 57s ⏱️ -11s
4 886 tests +56  4 655 ✅ +49  231 💤 +7  0 ❌ ±0 
6 331 runs  +56  6 047 ✅ +49  284 💤 +7  0 ❌ ±0 

Results for commit 8c1dc9b. ± Comparison against base commit 4273e2d.

@hahn-kev hahn-kev merged commit ce1ab69 into master Aug 15, 2024
3 checks passed
@hahn-kev hahn-kev deleted the fix-l10n-workflow-support-dotnet-8 branch August 15, 2024 11:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants