Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed a couple strings that were not properly internationalized. #1173

Merged
merged 6 commits into from
Jun 7, 2022

Conversation

tombogle
Copy link
Contributor

@tombogle tombogle commented Jun 6, 2022

This change is Reviewable

@tombogle tombogle requested a review from jasonleenaylor June 6, 2022 14:11
@tombogle tombogle self-assigned this Jun 6, 2022
@tombogle
Copy link
Contributor Author

tombogle commented Jun 6, 2022

Note: Ideally, L10nSharp should be enhanced to get entire string when it is split across lines: sillsdev/l10nsharp#99

Copy link
Contributor

@jasonleenaylor jasonleenaylor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: 0 of 1 files reviewed, 1 unresolved discussion (waiting on @tombogle)


SIL.Windows.Forms/ImageToolbox/AcquireImageControl.cs line 10 at r1 (raw file):

using SIL.Reporting;
using System.Drawing.Imaging;
using Microsoft.SqlServer.Server;

Is this really necessary?

Code quote:

using Microsoft.SqlServer.Server;

@tombogle
Copy link
Contributor Author

tombogle commented Jun 6, 2022

SIL.Windows.Forms/ImageToolbox/AcquireImageControl.cs line 10 at r1 (raw file):

Previously, jasonleenaylor (Jason Naylor) wrote…

Is this really necessary?

No

Copy link
Contributor

@jasonleenaylor jasonleenaylor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed all commit messages.
Reviewable status: 0 of 1 files reviewed, all discussions resolved (waiting on @tombogle)

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
Copy link
Contributor

@jasonleenaylor jasonleenaylor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 1 of 1 files at r3.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @tombogle)

@jasonleenaylor jasonleenaylor enabled auto-merge (rebase) June 7, 2022 15:03

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
@jasonleenaylor jasonleenaylor merged commit 993349a into master Jun 7, 2022
@jasonleenaylor jasonleenaylor deleted the 118n-fix branch June 7, 2022 15:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants