-
-
Notifications
You must be signed in to change notification settings - Fork 50
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixed a couple strings that were not properly internationalized. #1173
Conversation
Note: Ideally, L10nSharp should be enhanced to get entire string when it is split across lines: sillsdev/l10nsharp#99 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status: 0 of 1 files reviewed, 1 unresolved discussion (waiting on @tombogle)
SIL.Windows.Forms/ImageToolbox/AcquireImageControl.cs
line 10 at r1 (raw file):
using SIL.Reporting; using System.Drawing.Imaging; using Microsoft.SqlServer.Server;
Is this really necessary?
Code quote:
using Microsoft.SqlServer.Server;
Previously, jasonleenaylor (Jason Naylor) wrote…
No |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed all commit messages.
Reviewable status: 0 of 1 files reviewed, all discussions resolved (waiting on @tombogle)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 1 of 1 files at r3.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @tombogle)
This change is