Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

History apis #18

Merged
merged 10 commits into from
Nov 7, 2024
Merged

History apis #18

merged 10 commits into from
Nov 7, 2024

Conversation

hahn-kev
Copy link
Collaborator

the apis to get objects at a given time/commit were poor, so I've changed that

Copy link
Contributor

@myieye myieye left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good 👍
I found a few typos and have a few suggestions.

src/SIL.Harmony.Tests/Db/QueryHelperTests.cs Show resolved Hide resolved
src/SIL.Harmony.Tests/ModelSnapshotTests.cs Show resolved Hide resolved
src/SIL.Harmony.Tests/ModelSnapshotTests.cs Show resolved Hide resolved
src/SIL.Harmony.Tests/ModelSnapshotTests.cs Show resolved Hide resolved
src/SIL.Harmony/Db/CrdtRepository.cs Outdated Show resolved Hide resolved
src/SIL.Harmony/Db/CrdtRepository.cs Outdated Show resolved Hide resolved
@hahn-kev hahn-kev requested a review from myieye November 6, 2024 06:26
Copy link
Contributor

@myieye myieye left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good 😎

src/SIL.Harmony/Db/CrdtRepository.cs Show resolved Hide resolved
src/SIL.Harmony.Tests/ModelSnapshotTests.cs Show resolved Hide resolved
@hahn-kev hahn-kev merged commit 481acfc into main Nov 7, 2024
4 checks passed
@hahn-kev hahn-kev deleted the history-apis branch November 7, 2024 04:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants