Skip to content

Commit

Permalink
only comment when there's an alert, make performance good again
Browse files Browse the repository at this point in the history
  • Loading branch information
hahn-kev committed Oct 29, 2024
1 parent c5bbd2b commit b1a1041
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 3 deletions.
3 changes: 1 addition & 2 deletions .github/workflows/test.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,6 @@ jobs:
output-file-path: src/artifacts/bin/SIL.Harmony.Tests/release/BenchmarkDotNet.Artifacts/results/SIL.Harmony.Tests.DataModelPerformanceBenchmarks-report-full-compressed.json
external-data-json-path: ./cache/benchmark-data.json
fail-on-alert: true
summary-always: true
comment-always: true
comment-on-alert: true
github-token: ${{ secrets.GITHUB_TOKEN }}

2 changes: 1 addition & 1 deletion src/SIL.Harmony.Tests/DataModelPerformanceTests.cs
Original file line number Diff line number Diff line change
Expand Up @@ -203,7 +203,7 @@ public void GlobalSetup()
[IterationSetup]
public void IterationSetup()
{
_emptyDataModel = new(alwaysValidate: false, performanceTest: false);
_emptyDataModel = new(alwaysValidate: false, performanceTest: true);
_ = _emptyDataModel.WriteNextChange(_emptyDataModel.SetWord(Guid.NewGuid(), "entity1")).Result;
_dataModelTestBase = _templateModel.ForkDatabase(false);
}
Expand Down

0 comments on commit b1a1041

Please sign in to comment.