Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue#3525: Goal class has unused field: user #3526

Merged

Conversation

syamjir
Copy link
Contributor

@syamjir syamjir commented Jan 16, 2025

Hi sillsdev,

I have removed the user-related properties and imports from the Goal class and simplified the constructor and related code.

Please review the changes and provide any feedback.

Thank you!

Resolves #3525


This change is Reviewable

Copy link

codecov bot commented Jan 16, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 66.51%. Comparing base (fcd1a2b) to head (120969f).
Report is 1 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #3526      +/-   ##
==========================================
- Coverage   74.55%   66.51%   -8.05%     
==========================================
  Files         286      235      -51     
  Lines       11022     5844    -5178     
  Branches     1344      712     -632     
==========================================
- Hits         8218     3887    -4331     
+ Misses       2417     1729     -688     
+ Partials      387      228     -159     
Flag Coverage Δ
backend ?
frontend 66.51% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@imnasnainaec
Copy link
Collaborator

Thanks for contributing @syamjir.

Please delete the 4 lines completely, rather than leaving extra empty lines in their places.

@imnasnainaec imnasnainaec self-assigned this Jan 16, 2025
@imnasnainaec imnasnainaec added frontend maintenance Issue that makes it difficult to maintain the software or to upgrade installations post-release. goal labels Jan 16, 2025
@syamjir
Copy link
Contributor Author

syamjir commented Jan 17, 2025

@imnasnainaec ,Okay, I will delete those empty lines and submit the pull request shortly.

Copy link
Collaborator

@imnasnainaec imnasnainaec left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 1 of 1 files at r2, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @syamjir)

@imnasnainaec imnasnainaec enabled auto-merge (squash) January 17, 2025 16:22
@imnasnainaec imnasnainaec merged commit 0b4e971 into sillsdev:master Jan 17, 2025
18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
frontend goal maintenance Issue that makes it difficult to maintain the software or to upgrade installations post-release.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Goal class has unused field: user
2 participants