Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update setup dotnet #3524

Closed

Conversation

hahn-kev
Copy link
Contributor

@hahn-kev hahn-kev commented Jan 16, 2025

was v4.0.1 to v4.2.0, this should fix the workflow failures. This was caused by the this


This change is Reviewable

was v4.0.1 to v4.2.0
Copy link

codecov bot commented Jan 16, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 74.55%. Comparing base (0947624) to head (581c1d5).

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #3524   +/-   ##
=======================================
  Coverage   74.55%   74.55%           
=======================================
  Files         286      286           
  Lines       11022    11022           
  Branches     1344     1344           
=======================================
  Hits         8217     8217           
  Misses       2418     2418           
  Partials      387      387           
Flag Coverage Δ
backend 83.62% <ø> (ø)
frontend 66.51% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@imnasnainaec imnasnainaec left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed all commit messages.
Reviewable status: 0 of 1 files reviewed, 1 unresolved discussion (waiting on @hahn-kev)


.github/workflows/backend.yml line 35 at r1 (raw file):

            deb.debian.org:80
            dotnetbuilds.azureedge.net:443
            dotnetcli.azureedge.net:443

The bump to 4.2.0 should allow removing the three *.azureedge.net:443 endpoints from this file, no?

@hahn-kev
Copy link
Contributor Author

Yeah I think we can remove those now

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants