Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MergeDups] Extract protected-reasons-text functions #3489

Merged
merged 6 commits into from
Jan 14, 2025
Merged

Conversation

imnasnainaec
Copy link
Collaborator

@imnasnainaec imnasnainaec commented Dec 16, 2024

Prequel to #3445

Screenshots to demonstrate that the protected reasons are still showing:
Screenshot 2025-01-13 165725
Screenshot 2025-01-13 165749


This change is Reviewable

Copy link

codecov bot commented Dec 16, 2024

Codecov Report

Attention: Patch coverage is 2.12766% with 46 lines in your changes missing coverage. Please review.

Project coverage is 74.62%. Comparing base (a7a0b33) to head (af3508d).
Report is 1 commits behind head on master.

Files with missing lines Patch % Lines
...ergeDuplicates/MergeDupsStep/protectReasonUtils.ts 2.22% 44 Missing ⚠️
...uplicates/MergeDupsStep/MergeDragDrop/DropWord.tsx 0.00% 1 Missing ⚠️
...MergeDuplicates/MergeDupsStep/SenseCardContent.tsx 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #3489      +/-   ##
==========================================
- Coverage   74.67%   74.62%   -0.05%     
==========================================
  Files         285      286       +1     
  Lines       10995    11001       +6     
  Branches     1337     1338       +1     
==========================================
- Hits         8211     8210       -1     
- Misses       2401     2408       +7     
  Partials      383      383              
Flag Coverage Δ
backend 83.62% <ø> (ø)
frontend 66.63% <2.12%> (-0.09%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@imnasnainaec imnasnainaec changed the title Extract protected-reasons-text functions [MergeDups] Extract protected-reasons-text functions Dec 16, 2024
Copy link
Collaborator

@andracc andracc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 3 of 3 files at r2, 1 of 1 files at r3, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @imnasnainaec)

@imnasnainaec imnasnainaec merged commit f5f778e into master Jan 14, 2025
18 checks passed
@imnasnainaec imnasnainaec deleted the reasons-text branch January 14, 2025 17:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants