Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[User Guide] Add custom semantic domains info #3218

Merged
merged 2 commits into from
Jul 2, 2024

Conversation

imnasnainaec
Copy link
Collaborator

@imnasnainaec imnasnainaec commented Jul 2, 2024

User Guide update for #3081


This change is Reviewable

@imnasnainaec imnasnainaec added the documentation Improvements or additions to documentation label Jul 2, 2024
@imnasnainaec imnasnainaec self-assigned this Jul 2, 2024
Copy link

codecov bot commented Jul 2, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 74.82%. Comparing base (157753b) to head (3743e79).

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #3218      +/-   ##
==========================================
- Coverage   74.86%   74.82%   -0.04%     
==========================================
  Files         277      277              
  Lines       10622    10622              
  Branches     1270     1270              
==========================================
- Hits         7952     7948       -4     
- Misses       2307     2310       +3     
- Partials      363      364       +1     
Flag Coverage Δ
backend 83.84% <ø> (-0.09%) ⬇️
frontend 66.83% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@imnasnainaec imnasnainaec changed the title [User Guide] Add custom domains info [User Guide] Add custom semantic domains info Jul 2, 2024
Copy link
Contributor

@jasonleenaylor jasonleenaylor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 24 of 24 files at r1, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @imnasnainaec)

Copy link
Contributor

@jasonleenaylor jasonleenaylor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 3 of 3 files at r2, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @imnasnainaec)

@imnasnainaec imnasnainaec merged commit 89906ef into master Jul 2, 2024
18 checks passed
@imnasnainaec imnasnainaec deleted the sem-dom-user-guide branch July 2, 2024 16:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants