Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: address zizmor's findings #336

Merged
merged 1 commit into from
Nov 19, 2024
Merged

Conversation

woodruffw
Copy link
Member

@woodruffw woodruffw commented Nov 19, 2024

This addresses a bunch of low-impact findings from zizmor, all of which are disabling unneeded credential persistence or moving permissions: stanzas into their dependent jobs.

NB: This changeset doesn't include a new workflow for zizmor, but if folks are interested this one should be drag-n-drop 🙂

Afterwards:

$ zizmor .
🌈 completed codeql.yml
🌈 completed golangci-lint.yml
🌈 completed verify_license.yml
🌈 completed depsreview.yml
🌈 completed build.yml
🌈 completed scorecard.yml
🌈 completed conformance.yml
No findings to report. Good job!

Signed-off-by: William Woodruff <[email protected]>
@woodruffw woodruffw requested a review from a team as a code owner November 19, 2024 22:44
Copy link
Member

@codysoyland codysoyland left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very cool, thanks @woodruffw

@codysoyland codysoyland merged commit 849f33f into sigstore:main Nov 19, 2024
10 checks passed
@woodruffw woodruffw deleted the ww/zizmor branch November 19, 2024 23:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants