Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make unsafe uses of Verify function explicit / make Verify options safe by default #3

Merged
merged 16 commits into from
Oct 2, 2023
Merged

Make unsafe uses of Verify function explicit / make Verify options safe by default #3

merged 16 commits into from
Oct 2, 2023

Commits on Sep 27, 2023

  1. Renamed Verify to VerifyUnsafe. 

    Introduced VerifyWithArtifact and VerifyWithArtifactDigest to make it
explicit what the preferred usage path is; users should not use
VerifyUnsafe unless they are very very careful and know what they are
doing.
    @phillmv
    phillmv committed Sep 27, 2023
    Configuration menu
    Copy the full SHA
    3b4f23e View commit details
    Browse the repository at this point in the history

  2. gofmt -s

    @phillmv
    phillmv committed Sep 27, 2023
    Configuration menu
    Copy the full SHA
    91f6fc3 View commit details
    Browse the repository at this point in the history

Commits on Sep 29, 2023

  1. Reverted VerifyUnsafe, VerifyWith* funcs.

    @phillmv
    phillmv committed Sep 29, 2023
    Configuration menu
    Copy the full SHA
    06f8f08 View commit details
    Browse the repository at this point in the history

  2. Introduced new WithoutIdentitiesUnsafe, WithoutArtifactUnsafe policy … 

    …options.
    @phillmv
    phillmv committed Sep 29, 2023
    Configuration menu
    Copy the full SHA
    c24c5e7 View commit details
    Browse the repository at this point in the history

  3. Merge branch 'main' into make-verify-interface-clearer 

    Signed-off-by: Phill MV <[email protected]>
    @phillmv
    phillmv committed Sep 29, 2023
    Configuration menu
    Copy the full SHA
    e00c64c View commit details
    Browse the repository at this point in the history

  4. Updated comments. 

    Signed-off-by: Phill MV <[email protected]>
    @phillmv
    phillmv committed Sep 29, 2023
    Configuration menu
    Copy the full SHA
    643a681 View commit details
    Browse the repository at this point in the history

  5. Encapsulated the construction of PolicyConfig inside PolicyBuilder, 

    added validation checks.

Signed-off-by: Phill MV <[email protected]>
    @phillmv
    phillmv committed Sep 29, 2023
    Configuration menu
    Copy the full SHA
    3fc2f32 View commit details
    Browse the repository at this point in the history

  6. Made receiver variables consistent with other PolicyOptions. 

    Signed-off-by: Phill MV <[email protected]>
    @phillmv
    phillmv committed Sep 29, 2023
    Configuration menu
    Copy the full SHA
    11ccc70 View commit details
    Browse the repository at this point in the history

  7. Linting. 

    Signed-off-by: Phill MV <[email protected]>
    @phillmv
    phillmv committed Sep 29, 2023
    Configuration menu
    Copy the full SHA
    f8a40f9 View commit details
    Browse the repository at this point in the history

  8. Added a length check in case no certificate identities are provided. 

    Signed-off-by: Phill MV <[email protected]>
    @phillmv
    phillmv committed Sep 29, 2023
    Configuration menu
    Copy the full SHA
    392c5e5 View commit details
    Browse the repository at this point in the history

Commits on Oct 2, 2023

  1. renamed variable to identityPolicies.

    @phillmv
    phillmv committed Oct 2, 2023
    Configuration menu
    Copy the full SHA
    8dc24e5 View commit details
    Browse the repository at this point in the history

  2. Removed unnecessary pointer deref.

    @phillmv
    phillmv committed Oct 2, 2023
    Configuration menu
    Copy the full SHA
    650a0e4 View commit details
    Browse the repository at this point in the history

  3. Renamed VerifierConfigurator type to VerifierOption for consistency w… 

    …ith PolicyOption.
    @phillmv
    phillmv committed Oct 2, 2023
    Configuration menu
    Copy the full SHA
    340d95e View commit details
    Browse the repository at this point in the history

  4. Toned down some of the comments around Unsafe PolicyOptions. 

    Signed-off-by: Phill MV <[email protected]>
    @phillmv
    phillmv committed Oct 2, 2023
    Configuration menu
    Copy the full SHA
    975b16c View commit details
    Browse the repository at this point in the history

  5. On 2nd thought, BuildConfig ought to return a pointer. 

    This way, we can't accidentally use a default PolicyConfig struct.

Signed-Off-By: Phill MV <[email protected]>
    @phillmv
    phillmv committed Oct 2, 2023
    Configuration menu
    Copy the full SHA
    6f268a1 View commit details
    Browse the repository at this point in the history

  6. Added tests for policy options, made existing test use Safe path. 

    Signed-Off-By: Phill MV <[email protected]>
    @phillmv
    phillmv committed Oct 2, 2023
    Configuration menu
    Copy the full SHA
    fc8568c View commit details
    Browse the repository at this point in the history