Write range sync tests in external event-driven form #6618
+329
−512
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dapplion
added
ready-for-review
jimmygchen
reviewed
Dec 12, 2024
| rig.remember_block(finalized_peer_block); | ||
|
|
||
| // Add an additional peer to the second chain to make range update it's status | ||
| rig.add_finalized_peer(); |
There was a problem hiding this comment.
I don't really understand what this line does - do we need to assert for some condition after doing this?
jimmygchen
reviewed
Dec 12, 2024
| let block_root = | ||
| tokio::runtime::Runtime::new() | ||
| .unwrap() | ||
| .block_on(self.harness.extend_chain( |
There was a problem hiding this comment.
Maybe consider using async/await here instead of creating a new tokio::Runtime - might keep things simpler and avoid the extra overhead?
| fn remember_block(&mut self, block: SignedBeaconBlock<E>) { | ||
| tokio::runtime::Runtime::new() | ||
| .unwrap() | ||
| .block_on(self.harness.process_block( |
|
Nice! Looks clean and easy to read 👍 |
jimmygchen
added
waiting-on-author
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue Addressed
Re-write existing range sync tests into an event-driven format to accommodate the refactor introduced in
This format was introduced in
and does not make assumptions about internal functions, it treats sync as a black box inputting actual events used in production.
Note: I've removed the generics used in range sync since now we don't unit test directly