Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: prompt confirmation for fs write operations outside cwd #90

Merged
merged 1 commit into from
Aug 2, 2024
Merged

feat: prompt confirmation for fs write operations outside cwd #90

merged 1 commit into from
Aug 2, 2024

Conversation

sigoden
Copy link
Owner

@sigoden sigoden commented Aug 2, 2024

FS_BASE_DIR does not work properly, see #70 (comment)

We are changing to a new security policy:

  • Always allow read operations.
  • Always allow write operations that only affect the current directory.
  • For other operations, prompt for confirmation.

image

@sigoden sigoden merged commit d66d893 into main Aug 2, 2024
3 checks passed
@sigoden sigoden deleted the feat branch August 2, 2024 15:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@sigoden