-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: OTEL logging support #876
Conversation
CLA Assistant Lite bot All contributors have signed the CLA ✍️ ✅ |
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #876 +/- ##
==========================================
- Coverage 86.22% 85.97% -0.26%
==========================================
Files 19 19
Lines 668 670 +2
Branches 153 154 +1
==========================================
Hits 576 576
- Misses 92 94 +2 ☔ View full report in Codecov by Sentry. |
I have read the CLA Document and I hereby sign the CLA |
recheck |
recheck |
recheck |
I have read the CLA Document and I hereby sign the CLA |
src/logging/index.ts
Outdated
|
||
if (!serviceName) { | ||
diag.warn( | ||
'service.name attribute is not set, your service is unnamed and will be difficult to identify. ' + |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Might want to specify that it is from the logging part, else we'll get 2 identical warnings (1 from tracing)
recheck |
No description provided.