Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: OTEL logging support #876

Merged
merged 4 commits into from
Feb 12, 2024
Merged

feat: OTEL logging support #876

merged 4 commits into from
Feb 12, 2024

Conversation

mhennoch
Copy link
Contributor

@mhennoch mhennoch commented Feb 6, 2024

No description provided.

@mhennoch mhennoch requested review from a team as code owners February 6, 2024 15:03
Copy link

github-actions bot commented Feb 6, 2024

CLA Assistant Lite bot All contributors have signed the CLA ✍️ ✅

@codecov-commenter
Copy link

codecov-commenter commented Feb 6, 2024

Codecov Report

Attention: 2 lines in your changes are missing coverage. Please review.

Comparison is base (ce51170) 86.22% compared to head (5e76661) 85.97%.
Report is 1 commits behind head on main.

Files Patch % Lines
src/instrument.ts 0.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #876      +/-   ##
==========================================
- Coverage   86.22%   85.97%   -0.26%     
==========================================
  Files          19       19              
  Lines         668      670       +2     
  Branches      153      154       +1     
==========================================
  Hits          576      576              
- Misses         92       94       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mhennoch
Copy link
Contributor Author

mhennoch commented Feb 6, 2024

I have read the CLA Document and I hereby sign the CLA

@mhennoch
Copy link
Contributor Author

mhennoch commented Feb 6, 2024

recheck

@seemk
Copy link
Contributor

seemk commented Feb 6, 2024

CLA Assistant Lite bot: Thank you for your submission, we really appreciate it. Like many open-source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution. You can sign the CLA by just posting a Pull Request Comment same as the below format.

I have read the CLA Document and I hereby sign the CLA

You can retrigger this bot by commenting recheck in this Pull Request

recheck

@seemk seemk closed this Feb 6, 2024
@seemk seemk reopened this Feb 6, 2024
@github-actions github-actions bot locked and limited conversation to collaborators Feb 6, 2024
@mhennoch mhennoch requested a review from a team as a code owner February 7, 2024 15:35
@mhennoch
Copy link
Contributor Author

mhennoch commented Feb 7, 2024

recheck

@mhennoch mhennoch removed the request for review from a team February 7, 2024 16:13
@mhennoch
Copy link
Contributor Author

mhennoch commented Feb 7, 2024

I have read the CLA Document and I hereby sign the CLA


if (!serviceName) {
diag.warn(
'service.name attribute is not set, your service is unnamed and will be difficult to identify. ' +
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Might want to specify that it is from the logging part, else we'll get 2 identical warnings (1 from tracing)

@seemk
Copy link
Contributor

seemk commented Feb 12, 2024

recheck

@signalfx signalfx unlocked this conversation Feb 12, 2024
@seemk seemk merged commit 8725aaa into main Feb 12, 2024
130 checks passed
@seemk seemk deleted the log-sdk branch February 12, 2024 17:27
@github-actions github-actions bot locked and limited conversation to collaborators Feb 12, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants