Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Docker multi-arch support #815

Merged
merged 2 commits into from
Oct 13, 2023
Merged

Docker multi-arch support #815

merged 2 commits into from
Oct 13, 2023

Conversation

atoulme
Copy link
Contributor

@atoulme atoulme commented Oct 13, 2023

  • Add additional platform support for the Docker images
  • Allow manual push of images

@atoulme atoulme requested review from a team as code owners October 13, 2023 20:02
@codecov-commenter
Copy link

codecov-commenter commented Oct 13, 2023 •
edited
Loading

Codecov Report

All modified lines are covered by tests ✅

Comparison is base (5cc2612) 86.22% compared to head (896c644) 86.22%.

Additional details and impacted files 
@@           Coverage Diff           @@
##             main     #815   +/-   ##
=======================================
  Coverage   86.22%   86.22%           
=======================================
  Files          19       19           
  Lines         668      668           
  Branches      153      153           
=======================================
  Hits          576      576           
  Misses         92       92

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@seemk seemk enabled auto-merge (squash) October 13, 2023 20:11
@seemk seemk disabled auto-merge October 13, 2023 20:11
@atoulme atoulme force-pushed the add_additional_docker_platforms branch from 4d87de6 to 35590a6 Compare October 13, 2023 20:24
@seemk
Copy link
Contributor

seemk commented Oct 13, 2023

Can't merge due to the unrelated link check failure, could you set fail: false in .github/workflows/check-links.yml? I'll deal with this on Monday (don't think changelog should be in the link checker anyway) and I can't open a PR myself at the moment as there is no one to approve it atm

@atoulme atoulme force-pushed the add_additional_docker_platforms branch from 0145741 to 896c644 Compare October 13, 2023 20:38
@seemk seemk merged commit 42a8bbd into signalfx:main Oct 13, 2023
46 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jvoravong jvoravong jvoravong approved these changes

@seemk seemk seemk approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@atoulme @codecov-commenter @seemk @jvoravong