Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: native extension: support older C++ ABIs #806

Merged
merged 18 commits into from
Oct 2, 2023
Merged

fix: native extension: support older C++ ABIs #806

merged 18 commits into from
Oct 2, 2023

Conversation

seemk
Copy link
Contributor

@seemk seemk commented Sep 30, 2023

Prebuilds now work with CentOS 7 (and any other OS with ancient glibc++), getting rid of the need to install g++ and Python for the compile step.

  • Get rid of C++ standard library in the native extension.
    • Replace std::chrono::system_clock with OS builtins.
    • Replace std::vector with tinystl::vector
    • Use const char* instead of std::string (really small strings)
  • Add CentOS 7 build and prebuilds check to CI.

@seemk seemk requested review from a team as code owners September 30, 2023 18:51
@codecov-commenter
Copy link

Codecov Report

All modified lines are covered by tests ✅

Comparison is base (887b5ed) 86.22% compared to head (6d7b754) 86.22%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #806   +/-   ##
=======================================
  Coverage   86.22%   86.22%           
=======================================
  Files          19       19           
  Lines         668      668           
  Branches      153      153           
=======================================
  Hits          576      576           
  Misses         92       92           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@seemk seemk merged commit 510ee2a into main Oct 2, 2023
90 checks passed
@seemk seemk deleted the cxxlib_reduction branch October 2, 2023 14:01
@seemk seemk mentioned this pull request Oct 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants