fix: support 'none' value for OTEL_METRICS_EXPORTER (#801)

signalfx · Sep 20, 2023 · 8681bfc · 8681bfc
1 parent 2408364
commit 8681bfc
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 1 deletion.
diff --git a/src/metrics/index.ts b/src/metrics/index.ts
@@ -128,7 +128,7 @@ function recordGcCountMetric(counter: Counter, counters: NativeCounters) {
   }
 }
 
-const SUPPORTED_EXPORTER_TYPES = ['console', 'otlp'];
+const SUPPORTED_EXPORTER_TYPES = ['console', 'otlp', 'none'];
 
 function areValidExporterTypes(types: string[]): boolean {
   return types.every((t) => SUPPORTED_EXPORTER_TYPES.includes(t));

diff --git a/test/metrics.options.test.ts b/test/metrics.options.test.ts
@@ -57,6 +57,12 @@ describe('metrics options', () => {
       assert(readers[1]['_exporter'] instanceof ConsoleMetricExporter);
     });
 
+    it('does not create an exporter for none value', () => {
+      process.env.OTEL_METRICS_EXPORTER = 'none';
+      const options = _setDefaultOptions();
+      assert.deepStrictEqual(options.metricReaderFactory(options), []);
+    });
+
     it('throws on invalid key', () => {
       process.env.OTEL_METRICS_EXPORTER = 'invalid-key';