fix: reported profiling stack frame count (#886)

signalfx · Feb 22, 2024 · 6bed434 · 6bed434
1 parent ee90b71
commit 6bed434
Show file tree

Hide file tree

Showing 2 changed files with 20 additions and 3 deletions.
diff --git a/src/profiling/OTLPProfilingExporter.ts b/src/profiling/OTLPProfilingExporter.ts
@@ -16,7 +16,12 @@
 import * as protoLoader from '@grpc/proto-loader';
 import type * as grpc from '@grpc/grpc-js';
 import * as path from 'path';
-import { CpuProfile, HeapProfile, ProfilingExporter } from './types';
+import {
+  CpuProfile,
+  HeapProfile,
+  ProfilingExporter,
+  ProfilingStacktrace,
+} from './types';
 import { diag } from '@opentelemetry/api';
 import { Resource } from '@opentelemetry/resources';
 import { VERSION } from '@opentelemetry/core';
@@ -68,6 +73,16 @@ function commonAttributes(
   ];
 }
 
+function countSamples(stacktraces: ProfilingStacktrace[]) {
+  let sampleCount = 0;
+
+  for (const profilingStacktrace of stacktraces) {
+    sampleCount += profilingStacktrace.stacktrace.length;
+  }
+
+  return sampleCount;
+}
+
 export class OTLPProfilingExporter implements ProfilingExporter {
   protected _client: LogsClient;
   protected _options: OTLPExporterOptions;
@@ -140,7 +155,9 @@ export class OTLPProfilingExporter implements ProfilingExporter {
 
   send(profile: CpuProfile) {
     const { stacktraces } = profile;
-    const sampleCount = stacktraces?.length || 0;
+
+    const sampleCount = countSamples(stacktraces);
+
     diag.debug(`profiling: Exporting ${sampleCount} CPU samples`);
     const { callstackInterval } = this._options;
     const attributes = commonAttributes('cpu', sampleCount);

diff --git a/test/profiling/exporter.test.ts b/test/profiling/exporter.test.ts
@@ -104,7 +104,7 @@ describe('profiling OTLP exporter', () => {
             key: 'com.splunk.sourcetype',
             value: { stringValue: 'otel.profiling' },
           },
-          { key: 'profiling.data.total.frame.count', value: { intValue: 1 } },
+          { key: 'profiling.data.total.frame.count', value: { intValue: 2 } },
         ]);
 
         done();