Skip to content

Commit

Permalink
feat: support node21 for prebuilds (#838)
Browse files Browse the repository at this point in the history
* feat: support node21 for prebuilds

* fix node21 api target

* use python 3.11 for CI

* update node-abi

* use another python version for macos prebuilds

* use python 3.11 on macos for unit tests

* more better macos pythons
  • Loading branch information
seemk authored Nov 16, 2023
1 parent 394a79b commit 0ee5fd9
Show file tree
Hide file tree
Showing 4 changed files with 56 additions and 27 deletions.
24 changes: 22 additions & 2 deletions .github/workflows/ci.yml
Original file line number Diff line number Diff line change
Expand Up @@ -15,6 +15,8 @@ jobs:
include:
- container: 'node:16.0.0'
node_api_target: '20.0.0'
- container: 'node:16.0.0'
node_api_target: '21.2.0'
container: ${{ matrix.container }}
steps:
- name: Checkout
Expand All @@ -35,11 +37,17 @@ jobs:
fail-fast: false
matrix:
os: [windows-2019, macos-11]
node_api_target: ['14.0.0', '15.0.0', '16.0.0', '17.0.1', '18.0.0', '20.0.0']
node_api_target: ['14.0.0', '15.0.0', '16.0.0', '17.0.1', '18.0.0', '20.0.0', '21.2.0']
include:
- os: macos-11
python_version: '3.11'
runs-on: ${{ matrix.os }}
steps:
- name: Checkout
uses: actions/checkout@v3
- uses: actions/setup-python@v4
with:
python-version: ${{ matrix.python_version }}
- uses: actions/setup-node@v3
with:
node-version: '16'
Expand All @@ -59,6 +67,9 @@ jobs:
steps:
- name: Checkout
uses: actions/checkout@v3
- uses: actions/setup-python@v4
with:
python-version: '3.11'
- uses: actions/setup-node@v3
with:
node-version: '16'
Expand Down Expand Up @@ -89,10 +100,19 @@ jobs:
fail-fast: false
matrix:
os: ['ubuntu-latest', 'windows-2019', 'macos-latest']
nodejs: ['14', '16', '17', '18', '20']
nodejs: ['14', '16', '17', '18', '20', '21']
include:
- os: 'macos-latest'
python_version: '3.11'
- os: 'macos-latest'
nodejs: '14'
python_version: '3.10'
steps:
- name: Checkout
uses: actions/checkout@v3
- uses: actions/setup-python@v4
with:
python-version: ${{ matrix.python_version }}
- uses: actions/setup-node@v3
with:
node-version: ${{ matrix.nodejs }}
Expand Down
40 changes: 20 additions & 20 deletions package-lock.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

8 changes: 4 additions & 4 deletions package.json
Original file line number Diff line number Diff line change
Expand Up @@ -80,10 +80,10 @@
"eslint-plugin-node": "^11.1.0",
"eslint-plugin-prettier": "^4.2.1",
"gts": "^5.0.0",
"kafkajs": "^2.2.4",
"kafkajs": "^2.2.4",
"mocha": "^10.2.0",
"mysql2": "^2.2.5",
"nock": "^13.3.1",
"nock": "^13.3.1",
"nyc": "15.1.0",
"octokit": "^2.0.14",
"pg": "^8.4.2",
Expand Down Expand Up @@ -150,8 +150,8 @@
"@opentelemetry/sdk-trace-node": "1.17.1",
"@opentelemetry/semantic-conventions": "1.17.1",
"is-promise": "^4.0.0",
"nan": "^2.17.0",
"node-gyp-build": "^4.6.0",
"nan": "^2.18.0",
"node-gyp-build": "^4.6.1",
"protobufjs": "^7.2.4",
"semver": "^7.5.4"
},
Expand Down
11 changes: 10 additions & 1 deletion scripts/prebuild-os.js
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,16 @@ const prebuildify = require('prebuildify');
let targets = process.argv.slice(2);

if (targets.length == 0) {
targets = ['14.0.0', '15.0.0', '16.0.0', '17.0.1', '18.0.0', '19.0.0', '20.0.0'];
targets = [
'14.0.0',
'15.0.0',
'16.0.0',
'17.0.1',
'18.0.0',
'19.0.0',
'20.0.0',
'21.2.0'
];
}

prebuildify({
Expand Down

0 comments on commit 0ee5fd9

Please sign in to comment.