Add otlp exporter support behind config option #745
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mhennoch
reviewed
Feb 13, 2024
| // Changes: Add attribute serializing hook to remove data before export | ||
| spans = spans.map(span => { | ||
| // @ts-expect-error Yep we're overwriting a readonly property here. Deal with it | ||
| span.attributes = this._onAttributesSerializing ? this._onAttributesSerializing(span.attributes, span) : span.attributes; |
There was a problem hiding this comment.
this._onAttributesSerializing alway true no?
There was a problem hiding this comment.
should be, tho types says maybe
mhennoch
reviewed
Feb 13, 2024
mhennoch
approved these changes
Mar 14, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add configuration option
exporter.otlpthat switches from zipkin exporter to otlp/json, while extracting component rate limiter and adding some fixes for using transport based on state of the page (prefer xhr with beacon while unloading)Updated otel deps as they're back to working condition for web
Type of change
How has this been tested?
Tested by sending data to otel collector. This feature still needs a lot more testing against rum-ingest once that's available