Skip to content

Commit

Permalink
js ecosystem make things not suck challenge [impossible]
Browse files Browse the repository at this point in the history
  • Loading branch information
t2t2 committed Apr 17, 2024
1 parent 084f4e0 commit ecdfa4b
Show file tree
Hide file tree
Showing 5 changed files with 9 additions and 2 deletions.
1 change: 1 addition & 0 deletions packages/web/src/webvitals.ts
Original file line number Diff line number Diff line change
Expand Up @@ -15,6 +15,7 @@ limitations under the License.
*/

import { TracerProvider, Tracer } from '@opentelemetry/api';
// @ts-ignore TS1479 in commonjs

Check failure on line 18 in packages/web/src/webvitals.ts

View workflow job for this annotation

GitHub Actions / unit-tests

Use "@ts-expect-error" instead of "@ts-ignore", as "@ts-ignore" will do nothing if the following line is error-free
import { onCLS, onLCP, onFID, onINP, Metric } from 'web-vitals';
const reported = {};

Expand Down
3 changes: 2 additions & 1 deletion packages/web/tsconfig.base.json
Original file line number Diff line number Diff line change
@@ -1,7 +1,8 @@
{
"compilerOptions": {
"forceConsistentCasingInFileNames": true,
"moduleResolution": "node",
"module": "NodeNext",
"moduleResolution": "NodeNext",
"noEmitOnError": true,
"pretty": true,
"resolveJsonModule": true,
Expand Down
1 change: 1 addition & 0 deletions packages/web/tsconfig.cjs.json
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,7 @@
"compilerOptions": {
"declaration": true,
"module": "CommonJS",
"moduleResolution": "Node10",
"outDir": "./dist/cjs",
"rootDir": "src",
"sourceMap": true
Expand Down
2 changes: 1 addition & 1 deletion packages/web/tsconfig.esm.json
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
{
"compilerOptions": {
"declaration": true,
"module": "ES6",
"module": "NodeNext",
"outDir": "./dist/esm",
"rootDir": "src",
"sourceMap": true
Expand Down
4 changes: 4 additions & 0 deletions packages/web/tsconfig.test.json
Original file line number Diff line number Diff line change
@@ -1,4 +1,8 @@
{
"compilerOptions": {
"module": "NodeNext",
"moduleResolution": "NodeNext"
},
"include": [
"test/*.ts"
],
Expand Down

0 comments on commit ecdfa4b

Please sign in to comment.