chore: add tests

signalfx · Nov 8, 2024 · a407866 · a407866
1 parent 26be13a
commit a407866
Show file tree

Hide file tree

Showing 3 changed files with 43 additions and 36 deletions.
diff --git a/packages/integration-tests/playwright.config.ts b/packages/integration-tests/playwright.config.ts
@@ -60,34 +60,34 @@ export default defineConfig({
 	projects: [
 		{
 			name: 'chromium',
-			use: { ...devices['Desktop Chrome'] },
+			use: { ...devices['Desktop Chrome'], headless: false },
 		},
 
-		{
-			name: 'firefox',
-			use: { ...devices['Desktop Firefox'] },
-		},
-
-		{
-			name: 'webkit',
-			use: { ...devices['Desktop Safari'] },
-		},
-
-		{
-			name: 'edge',
-			use: {
-				...devices['Desktop Edge'],
-				channel: 'msedge',
-			},
-		},
-
-		{
-			name: 'chrome',
-			use: {
-				...devices['Desktop Chrome'],
-				channel: 'chrome',
-			},
-		},
+		// {
+		// 	name: 'firefox',
+		// 	use: { ...devices['Desktop Firefox'] },
+		// },
+		//
+		// {
+		// 	name: 'webkit',
+		// 	use: { ...devices['Desktop Safari'] },
+		// },
+		//
+		// {
+		// 	name: 'edge',
+		// 	use: {
+		// 		...devices['Desktop Edge'],
+		// 		channel: 'msedge',
+		// 	},
+		// },
+		//
+		// {
+		// 	name: 'chrome',
+		// 	use: {
+		// 		...devices['Desktop Chrome'],
+		// 		channel: 'chrome',
+		// 	},
+		// },
 	],
 
 	/* Run your local dev server before starting the tests */

diff --git a/packages/integration-tests/src/pages/record-page.ts b/packages/integration-tests/src/pages/record-page.ts
@@ -54,6 +54,10 @@ export class RecordPage {
 		return this.page.goto(absoluteUrl)
 	}
 
+	get locator() {
+		return this.page.locator.bind(this.page)
+	}
+
 	async mockNetwork() {
 		await this.page.route('*/**/api/v2/spans', async (route, request) => {
 			const spans = JSON.parse(request.postData())

diff --git a/.../tests/redacting-attributes/index.spec.js → .../tests/redacting-attributes/index.spec.ts b/.../tests/redacting-attributes/index.spec.js → .../tests/redacting-attributes/index.spec.ts
@@ -15,16 +15,19 @@
  * limitations under the License.
  *
  */
+import { test } from '../../utils/test'
+import { expect } from '@playwright/test'
 
-module.exports = {
-	'redacting attributes with custom exporter': async function (browser) {
-		const url = browser.globals.getUrl('/redacting-attributes/index.ejs')
-		await browser.url(url)
+test.describe('redacting-attributes', () => {
+	test('with custom exporter', async ({ recordPage }) => {
+		await recordPage.goTo('/redacting-attributes/index.ejs')
 
-		await browser.click('#btnClick')
+		await recordPage.locator('#btnClick').click()
 
-		const clickSpan = await browser.globals.findSpan((span) => span.name === 'click')
-		await browser.assert.ok(clickSpan)
-		await browser.assert.strictEqual(clickSpan.tags['http.url'], '[redacted]')
-	},
-}
+		await recordPage.waitForSpans((spans) => spans.some((s) => s.name === 'click'))
+		const receivedSpans = recordPage.receivedSpans
+		const clickSpans = receivedSpans.filter((span) => span.name === 'click')
+
+		expect(clickSpans.every((s) => s.tags['http.url'] === '[redacted]'))
+	})
+})