feature/APMI-2820 iOS crash does not retain old screen name #2
Conversation
changes in crashreporting.swift
| @@ -84,7 +94,9 @@ func loadPendingCrashReport(_ data: Data!) throws { | |||
| exceptionType = report.exceptionInfo.exceptionName | |||
| } | |||
|
|
|||
| let oldSessionId = String(decoding: report.customData, as: UTF8.self) | |||
| let strArr = String(decoding: report.customData, as: UTF8.self).components(separatedBy: "|") | |||
There was a problem hiding this comment.
This will break if the user specifiers a screen name containing a |. Please use something sensible like URL/URI encoding (which in Swift is apparently named addingPercentEncoding) and the same keys we would report with the span.
Changed logic of saving sessionid and screen name as custom data.
linting issue solved
| @@ -24,6 +24,9 @@ let CrashReportingVersionString = "0.2.0" | |||
|
|
|||
| var TheCrashReporter: PLCrashReporter? | |||
|
|
|||
| let keyID = "SessionID" | |||
There was a problem hiding this comment.
Might rename it sessionIdKey and screenNameKey or something similar, at the moment it's a bit hard to understand at first glance what is keyID and keyName
| } | ||
| } | ||
|
|
||
| func saveSessionIDInToCustomData() { |
minor changes
|
PR failed because of following line.
|
| @@ -84,7 +132,9 @@ func loadPendingCrashReport(_ data: Data!) throws { | |||
| exceptionType = report.exceptionInfo.exceptionName | |||
| } | |||
|
|
|||
| let oldSessionId = String(decoding: report.customData, as: UTF8.self) | |||
| guard let dict = dataToDictionary(data: report.customData) else {return} | |||
There was a problem hiding this comment.
We should make a best effort to report data, even if we are missing some fields. Missing the old session ID and/or the old screen name should not prevent us from reporting any crash reporting span.
remove guard let , send crash span if it has not sessionid or screen name data.
shattimare
changed the title
test case added to check that screen.name is there or not
changes in crashreporting.swift