Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use splunk-otel-js as Docker image for node.js auto-instrumentation #965

Merged
merged 8 commits into from
Oct 13, 2023

Conversation

atoulme
Copy link
Contributor

@atoulme atoulme commented Oct 13, 2023

No description provided.

@atoulme
Copy link
Contributor Author

atoulme commented Oct 13, 2023

Rerunning with the latest tests merged in to pick up any breaking changes on traces.

@atoulme atoulme marked this pull request as ready for review October 13, 2023 20:54
@atoulme atoulme requested review from a team as code owners October 13, 2023 20:54
@jvoravong
Copy link
Contributor

Add one more line to this PR here. "['java']" -> "['java', 'nodejs']

Otherwise. LGTM.

@atoulme atoulme merged commit b644e32 into main Oct 13, 2023
23 of 24 checks passed
@atoulme atoulme deleted the nodejs_image branch October 13, 2023 21:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants