-
Notifications
You must be signed in to change notification settings - Fork 151
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix Operator helm template issues #943
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dmitryax
reviewed
Oct 3, 2023
helm-charts/splunk-otel-collector/templates/operator/instrumentation.yaml
Outdated
Show resolved
Hide resolved
dmitryax
reviewed
Oct 3, 2023
helm-charts/splunk-otel-collector/templates/operator/instrumentation.yaml
Outdated
Show resolved
Hide resolved
helm-charts/splunk-otel-collector/templates/operator/instrumentation.yaml
Outdated
Show resolved
Hide resolved
dmitryax
reviewed
Oct 3, 2023
helm-charts/splunk-otel-collector/templates/operator/instrumentation.yaml
Outdated
Show resolved
Hide resolved
dmitryax
reviewed
Oct 3, 2023
dmitryax
reviewed
Oct 3, 2023
helm-charts/splunk-otel-collector/templates/operator/_helpers.tpl
Outdated
Show resolved
Hide resolved
jvoravong
changed the title
Fix Operator helm template bug
Fix Operator helm template issues
Oct 4, 2023
dmitryax
approved these changes
Oct 5, 2023
helm-charts/splunk-otel-collector/templates/operator/_helpers.tpl
Outdated
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
This PR resolves multiple smaller issues in the Helm template related to the of non-default Operator auto-instrumentation values, which previously could trigger deployment failures.
Link to Splunk Idea: #938 (Refers to Issue 1)
Issue 1:
splunkObservability.profilingEnabled
splunk-otel-collector.operator.extract-name-keys-from-dict-list
returns a list that wasn’t being casted accurately where used, necessitating atoYaml
ortoJson
for proper interpretation.splunk-otel-collector.operator.extract-name-keys-from-dict-list
tosplunk-otel-collector.operator.env-has
to exclusively return "true" or "false" string values.Issue 2:
operator.instrumentation.spec.env
operator.instrumentation.spec.sampler
include
function; a combination of "with" + "toYaml" should have been utilized instead.Issue 3:
operator.instrumentation.spec.{instrumentation_library}.env
printf
function. Environment variables set inopentelemetry.io/v1alpha1
Instrumentation must be strings.Testing:
The new example has been tested; it is both renderable and deployable locally.