Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update docs for operatorcrds migration #1619

Merged
merged 19 commits into from
Jan 17, 2025
Merged

Update docs for operatorcrds migration #1619

merged 19 commits into from
Jan 17, 2025

Conversation

jvoravong
Copy link
Contributor

Description:

  • Add breaking change and migration notes
  • Update values.schema.json to prevent misusage

@jvoravong jvoravong requested review from a team as code owners January 16, 2025 16:35
crobert-1
crobert-1 reviewed Jan 16, 2025
View reviewed changes
Copy link
Contributor

@crobert-1 crobert-1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just some documentation nits, thanks for adding so much information with the change!

I'm not familiar enough with functionality to confidently sign off, but nothing looks off from what I understand.

.chloggen/move-operator-crd-install-method.yaml Outdated Show resolved Hide resolved
docs/auto-instrumentation-install.md Outdated Show resolved Hide resolved
docs/auto-instrumentation-install.md Outdated Show resolved Hide resolved
docs/auto-instrumentation-install.md Show resolved Hide resolved
docs/auto-instrumentation-install.md Show resolved Hide resolved
dmitryax
dmitryax approved these changes Jan 17, 2025
View reviewed changes
Copy link
Contributor

@dmitryax dmitryax left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with Jina comments applied.

@jvoravong jvoravong changed the title Update docs and values.shema.json for operatorcrds migration Update docs for operatorcrds migration Jan 17, 2025
jinja2
jinja2 reviewed Jan 17, 2025
View reviewed changes
UPGRADING.md Outdated Show resolved Hide resolved
jinja2
jinja2 reviewed Jan 17, 2025
View reviewed changes
UPGRADING.md Outdated Show resolved Hide resolved
jinja2
jinja2 reviewed Jan 17, 2025
View reviewed changes
UPGRADING.md Outdated Show resolved Hide resolved
@jvoravong jvoravong merged commit a7dd9ad into main Jan 17, 2025
58 checks passed
@jvoravong jvoravong deleted the op-doc-update branch January 17, 2025 22:55
@github-actions github-actions bot locked and limited conversation to collaborators Jan 17, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@crobert-1 crobert-1 crobert-1 left review comments

@jinja2 jinja2 jinja2 approved these changes

@dmitryax dmitryax dmitryax approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@jvoravong @dmitryax @jinja2 @crobert-1