Update config for setting up internal metrics scraper #1573
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Update config for scraping internal metrics to use new config interface and loopback address. This also drops redundant attributes reported with the internal metrics: `net.host.name` and `server.address`.
dmitryax
force-pushed
the
update-default-config-temetry-metrics
branch
from
1ca8c69 to
eeb4a05
Compare
jinja2
reviewed
Dec 13, 2024
| @@ -847,7 +847,12 @@ exporters: | |||
| service: | |||
| telemetry: | |||
| metrics: | |||
| address: 0.0.0.0:8889 | |||
| readers: | |||
There was a problem hiding this comment.
Is this new config interface also default for the version we are on? I think 8889 is our custom port so we probably have to add this anyway but just curious
There was a problem hiding this comment.
Yeah, that's right. Default is the same, just different 8888 port
jinja2
approved these changes
Dec 13, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update config for scraping internal metrics to use new config interface and loopback address. This also drops redundant attributes reported with the internal metrics:
net.host.nameandserver.address.