Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make classes final to discourage type inheritance from these. #401

Closed
wants to merge 1 commit into from
Closed

Make classes final to discourage type inheritance from these. #401

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion signalfx-codahale/src/main/java/com/signalfx/codahale/reporter/MetricMetadataImpl.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@
import com.signalfx.codahale.metrics.MetricBuilder;
import com.signalfx.metrics.protobuf.SignalFxProtocolBuffers.MetricType;

public class MetricMetadataImpl implements MetricMetadata {
public final class MetricMetadataImpl implements MetricMetadata {
private final ConcurrentMap<Metric, Metadata> metaDataCollection;

public MetricMetadataImpl() {
Expand Down
2 changes: 1 addition & 1 deletion signalfx-codahale/src/main/java/com/signalfx/codahale/reporter/SignalFxReporter.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,7 +40,7 @@
* @deprecated Migrate to OpenTelemetry to send metric telemetry to Splunk.
*/
@Deprecated
public class SignalFxReporter extends ScheduledReporter {
public final class SignalFxReporter extends ScheduledReporter {
private final AggregateMetricSender aggregateMetricSender;
private final Set<MetricDetails> detailsToAdd;
private final MetricMetadata metricMetadata;
Expand Down
2 changes: 1 addition & 1 deletion signalfx-yammer/src/main/java/com/signalfx/codahale/reporter/MetricMetadataImpl.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@
*
*/

public class MetricMetadataImpl implements MetricMetadata {
public final class MetricMetadataImpl implements MetricMetadata {
private final ConcurrentMap<Metric, Metadata> metaDataCollection;

public MetricMetadataImpl() {
Expand Down
2 changes: 1 addition & 1 deletion signalfx-yammer/src/main/java/com/signalfx/codahale/reporter/SignalFxReporter.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,7 +37,7 @@
* @deprecated Migrate to OpenTelemetry to send metric telemetry to Splunk.
*/
@Deprecated
public class SignalFxReporter extends CustomScheduledReporter {
public final class SignalFxReporter extends CustomScheduledReporter {
private final AggregateMetricSender aggregateMetricSender;
private final Set<MetricDetails> detailsToAdd;
private final MetricMetadata metricMetadata;
Expand Down