Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecate writer package #209

Merged
merged 3 commits into from
Apr 18, 2024
Merged

Deprecate writer package #209

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
dc400b5
Deprecate writer package
pellared Apr 17, 2024
cdcf7de
Update README.md
pellared Apr 17, 2024
4e9d1d1
Update writer/README.md
pellared Apr 18, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion writer/README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,10 @@
See the [godoc](https://godoc.org/github.com/signalfx/signalfx-go/writer) for
information on what they are and how to use them.

> [!WARNING]
> `writer` package is **deprecated** and will reach End of Support on October 18, 2024.
> Use OpenTelemetry Go instead.

## Compiling

The buffer and writer are generated from a common template in the [`template`](./template)
Expand All @@ -13,4 +17,3 @@ install the code generation tool with `go get github.com/mauricelam/genny`.
Also, `span_[writer|buffer]_test.go` is automatically generated from
`datapoint_[writer|buffer]_test.go` by the same `go generate` command, so be
sure to make changes in the datapoint test module.

2 changes: 2 additions & 0 deletions writer/internal.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,6 +23,8 @@
// request at a time to ingest/gateway is probably not going to get enough
// throughput, as usually the network and HTTP RTT is the bottleneck at that
// point.
//
// Deprecated: Use OpenTelemetry Go instead.
package writer

//go:generate sh -c "cd template && ./gen.sh"
Expand Down
Loading